Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.1.3.1 release #7

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Prepare 0.1.3.1 release #7

merged 4 commits into from
Feb 14, 2024

Conversation

brianjosephmckeon
Copy link
Member

No description provided.

@brianjosephmckeon
Copy link
Member Author

@andrewthad The laws test suite is failing. No rush on fixing this.

@andrewthad
Copy link
Member

I've fixed all the Ord instances. It's strange that this had not been detected before now. It's uncommon to use the Ord instance for a Maybe-like type, so I doubt it was encountered by any applications. Anyway, good to have it fixed now.

@chessai
Copy link
Member

chessai commented Feb 5, 2024

I've fixed all the Ord instances. It's strange that this had not been detected before now. It's uncommon to use the Ord instance for a Maybe-like type, so I doubt it was encountered by any applications. Anyway, good to have it fixed now.

pretty crazy. i remember copying these from the much older version of this library.

glad it's fixed now! i should have added these tests before.

@andrewthad
Copy link
Member

What's strange is that the test for the Ord laws were already there. Either no one had ever noticed that the test suite was failing, or maybe something in quickcheck-classes or QuickCheck changed that caused this to start getting detected. I'll chalk it up to one of history's mysteries.

@brianjosephmckeon brianjosephmckeon merged commit 9f1f104 into main Feb 14, 2024
4 checks passed
@brianjosephmckeon brianjosephmckeon deleted the 0.1.3.1 branch February 14, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants